Support using image registry proxy in more cases.#8927
Merged
Conversation
blackpiglet
added
the
kind/changelog-not-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8927 +/- ##
=======================================
Coverage 59.56% 59.56%
=======================================
Files 370 370
Lines 40267 40267
=======================================
Hits 23987 23987
Misses 14778 14778
Partials 1502 1502 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blackpiglet
force-pushed
the
modify_image_usage
branch
3 times, most recently
from
060ec88 to
d3b9781
Compare
blackpiglet
force-pushed
the
modify_image_usage
branch
4 times, most recently
from
fd1bca3 to
704e04a
Compare
kaovilai
previously approved these changes
May 13, 2025
Collaborator
kaovilai
left a comment
kaovilai
left a comment
There was a problem hiding this comment.
lgtm.
Notes
The removal of the
useVolumeSnapshotsparameter from theKibishiiPrepareBeforeBackupandinstallKibishiifunctions doesn't affect the functionality because:
- The parameter wasn't actually used within those functions.
- The parameter is still used in the
RunKibishiiTestsfunction where it's needed for the backup configuration and post-backup verification.
blackpiglet
force-pushed
the
modify_image_usage
branch
from
704e04a to
bedbbae
Compare
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
blackpiglet
force-pushed
the
modify_image_usage
branch
from
bedbbae to
14e1055
Compare
ywk253100
approved these changes
May 14, 2025
Lyndon-Li
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.